cederom commented on PR #4105:
URL: https://github.com/apache/nuttx-apps/pull/4105#issuecomment-7072287059

   Points to raise:
   1. **It only covers commit 1** and the ACK loop that commit 2 breaks. 
Nothing tests the first-SYN timing or the `SO_SNDTIMEO` connect. If apps#4101 
covers those, link it from both PRs; if not, ask for a test.
   2. **The #4103 dependency is unclear.** This case doesn't use 
`nettest_tcpserver`. Ask what exactly needs #4103 (perhaps the group setup).
   3. **On master it hangs nsh instead of failing.** The ACK storm over the 
loopback device blocks the board. The PR has to stay a draft until 22144 has 
merged, or a CI run will stall instead of reporting a failure.
   4. Trivial: the time limit only compares `tv_sec`, so it can run up to about 
11 s. Fine for a test.
   
   **Verdict:** I'd ask for the window check in commit 2 before approving 
22144. Everything else there is nits plus the Impact note. 4105 can be approved 
once the dependency question is answered and 22144 has merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to