patacongo edited a comment on pull request #39:
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/39#issuecomment-699685857


   This is probably real code breakage.  Again, it is a screw-up in include 
paths:
   
       /usr/include/cygwin/socket.h:27:8: error: redefinition of 'struct 
sockaddr'
          27 | struct sockaddr {
             |        ^~~~~~~~
       In file included from /usr/include/w32api/winsock2.h:57,
                        from sim/up_wpcap.c:48:
       /usr/include/w32api/psdk_inc/_ip_types.h:70:8: note: originally defined 
here
          70 | struct sockaddr {
             |        ^~~~~~~~
       In file included from /usr/include/sys/socket.h:13,
                        from /usr/include/cygwin/in.h:21,
                        from /usr/include/netinet/in.h:12,
                        from sim/up_wpcap.c:57:
       /usr/include/cygwin/socket.h:39:8: error: redefinition of 'struct 
sockaddr_storage'
          39 | struct sockaddr_storage {
             |        ^~~~~~~~~~~~~~~~
       In file included from sim/up_wpcap.c:48:
       /usr/include/w32api/winsock2.h:269:10: note: originally defined here
         269 |   struct sockaddr_storage {
             |          ^~~~~~~~~~~~~
   
   sim_wcap.c hasn't been build in ages.  It is mixing Cygwin and Windows 
socket definitions.  As I recall, this is a host file and, hence should be 
using all Windows definitions.
   
   The likelihood that this still works (even if built correctly) is low.
   
   I will look into this too.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to