yamt commented on a change in pull request #1852: URL: https://github.com/apache/incubator-nuttx/pull/1852#discussion_r497987561
########## File path: libs/libc/unistd/lib_sysconf.c ########## @@ -241,6 +241,14 @@ long sysconf(int name) return 1; #endif + case _SC_PAGESIZE: +#ifdef CONFIG_MM_PGSIZE + return CONFIG_MM_PGSIZE; +#else +#define PAGESIZE 4096 Review comment: _SC_PAGESIZE is mainly for mmap and friends. glancing at our mmap implementation, i suspect the appropriate value is 1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org