patacongo commented on a change in pull request #415:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/415#discussion_r498322953
##########
File path: netutils/netinit/netinit.c
##########
@@ -357,6 +367,86 @@ static void netinit_set_macaddr(void)
# define netinit_set_macaddr()
#endif
+#ifdef CONFIG_FSUTILS_IPCFG
+/****************************************************************************
+ * Name: netinit_get_ipaddrs
+ *
+ * Description:
+ * Setup IP addresses.
+ *
+ * For 6LoWPAN, the IP address derives from the MAC address. Setting it
+ * to any user provided value is asking for trouble.
+ *
+ ****************************************************************************/
+
+static int netinit_get_ipaddrs(void)
+{
+#ifdef CONFIG_NETINIT_DHCPC
+ bool use_dhcp = false;
+#endif
+ bool use_static = false;
+#ifdef CONFIG_NET_IPv4
+ struct in_addr addr;
+ int ret;
+
+ ret = ipcfg_read(NET_DEVNAME, &g_netconf);
Review comment:
>
>
> I totally agree. I will push the minor changes in a bit....
Don't get me wrong. I think IPv6 support is critical, at least for static
IP assignment (IPv6 does not use DHCP but has a separate auto-configuration
feature). The only issue if we merge this now and incorporate another PR
later, or if we essentially close this and delay merging to add the IPv6
support.
Delaying the merge provides better assurance that the IPv6 support will not
be swept under the rug but pushes the feature to 10.1. Really your choice. I
have no strong opinion. I am just trying to point issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
