davids5 commented on a change in pull request #415:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/415#discussion_r498886681
##########
File path: netutils/netinit/netinit.c
##########
@@ -221,13 +221,22 @@
# define AF_INETX AF_INET6
#endif
-/* While the network is up, the network monitor really does nothing. It
- * will wait for a very long time while waiting, it can be awakened by a
- * signal indicating a change in network status.
+/* If using signal notification, raise by a the PHY, then while the network
+ * is up, the network monitor really does nothing. It will wait for a very
+ * long time while waiting, it can be awakened by a signal indicating a
+ * change in network status.
+ *
+ * If the network monitor is used in polled mode these values are set by the
+ * CONFIG_NETINIT_LOSS_POLL_RATE and CONFIG_NETINIT_ESTABLISH_POLL_RATE
*/
-#define LONG_TIME_SEC (60*60) /* One hour in seconds */
-#define SHORT_TIME_SEC (2) /* 2 seconds */
+#if !(defined(CONFIG_ARCH_PHY_POLLED))
+# define LONG_TIME_SEC (60*60) /* One hour in seconds */
Review comment:
If you look ad the code this is enabled from the bottom up. Formally by
ARCH_PHY_INTERRUPT and now also by ARCH_PHY_INTERRUPT.
It is this way because I am respecting the previous functionality 100%. I
find that to be respectful of all users. I explained to you before I do not
have HW with a PHY that has an IRQ, I test my changes. This approach ensures I
did not break other peoples code. If you can test it with **all** the options
submit a PR and I will be happy to retest what I need working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
