donghengqaz commented on a change in pull request #1958:
URL: https://github.com/apache/incubator-nuttx/pull/1958#discussion_r503230467
##########
File path: arch/xtensa/src/common/xtensa_createstack.c
##########
@@ -73,6 +73,18 @@
#define STACK_ALIGN_DOWN(a) ((a) & ~STACK_ALIGN_MASK)
#define STACK_ALIGN_UP(a) (((a) + STACK_ALIGN_MASK) & ~STACK_ALIGN_MASK)
+#ifdef CONFIG_XTENSA_USE_SEPERATE_IMEM
Review comment:
I see these macros are used in some places, and they are defined in
multi `*.c` files, so maybe we can move these into a new file like
`xtensa_mm.h` ,and let these `*.c` include `xtensa_mm.h`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
