EduardNiesner opened a new pull request #2010:
URL: https://github.com/apache/incubator-nuttx/pull/2010


   ## Summary
   In nuttx\arch\arm\src\stm32h7\stm32_spi.c, "txresult" is defined and used 
only if the CONFIG_STM32H7_SPI_DMA is defined.
   But in the spi_interrupt function, the txresult is used regardless of 
whether CONFIG_STM32H7_SPI_DMA is defined or not.
   ## Impact
   The build does not work if you configure SPI but you do not configure DMA
   ## Testing
   I made the code build and the SPI seems to work as expected - I am 
communicating with an at45db flash over SPI and mounted smartFS on it and the 
communication seems to work. I am not sure if the changes that I did are enough 
or if the entire spi_interrupt function should be surrounded by the #ifdef 
CONFIG_STM32H7_SPI_DMA condition as well (and also where it is called from).
   It would be good if someone with more experience that understands the impact 
of the change could look into it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to