patacongo commented on a change in pull request #2004: URL: https://github.com/apache/incubator-nuttx/pull/2004#discussion_r506970524
########## File path: arch/arm/src/imxrt/imxrt_flexcan.h ########## @@ -0,0 +1,125 @@ +/************************************************************************************ + * arch/arm/src/imxrt/imxrt_flexcan.h + * + * Copyright (C) 2020 Gregory Nutt. All rights reserved. Review comment: > > > @xiaoxiang781216 This one is based on s32k1xx_flexcan.h which is under the other (old) licence, so the code should retain the copyright. Or do I understand it wrong? Yes, but I am the author/coyright holder on that file. I have submitte both and ICLA and an SGA granting all NuttX software to the ASF. The license has not yet been changed on s32k1xx_flexcan.h but it should be. I also grant you the right to change the header to Apache 2.0. No new files may come into the repository with the old BSD license. So if the header is not changed, the the PR will have to be declined. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org