Ouss4 commented on pull request #2014: URL: https://github.com/apache/incubator-nuttx/pull/2014#issuecomment-712060459
> > > Hmm, I also found the following code in arm_initialize.c and arm_checkstack.c > > > I think we need to fix these as well. > > > > > > @masayuki2009 Yes, however the use in arm_initialize.c and arm_checkstack.c is correct. Both expect to get the bottom of the stack. The only issue is arm_assert that uses arm_intstack_base expecting to get the "top" of the stack. > > @Ouss4 > > Yeah, but the current use of arm_intstack_base() in in arm_initialize.c and arm_checkstack.c is very confusing for me. So I will introduce arm_intstack_allock() which returns the "bottom" address of the stack and will be called in arm_initialize.c and arm_checkstack.c Also, I will modify arm_intstack_base() so that I can return the "top" address of the stack. These modifications will be consistent with non-SMP case. > > What do you think? I agree, this is the correct way to fix it. This will eliminate any confusion and be consistent with non-SMP case. I'll modify this PR to include these changes too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
