davids5 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712434684
@btashton. @v01d, @Donny9 @xiaoxiang781216 - I am testing 10.0.0 and ran into some really bad side affects of this change in the stm32f7 and I will assume all stm32xxx and possible a lot of other archs, Removing c_speed and folding the speed into the c_cflag breaks all the code that assumed these are separate. Here is an example: https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/stm32/stm32_serial.c#L2022-L2038 There are no not public macros either to isolate the fields and merge them. The published GPL code this copies has https://code.woboq.org/userspace/glibc/sysdeps/unix/sysv/linux/bits/termios-baud.h.html#25 I would not release 10.0.0 with this breakage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
