Donny9 commented on pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712681721
> > > > > > I also like the idea of unifying interfaces and reducing the need to repeat it across each sensor. But I worry if this is really a general sensor solution. Mainly since this introduces an intermediate buffering which may not be desired (due to space and added processing, in contrast to simply have the lower half write into the buffer passed by the caller). Maybe this buffer could optionally be disabled somehow. > > > > > > > > > Seems like we could add an interface to register a buffer with the driver? IIO has this internal interface: > > > https://www.kernel.org/doc/html/latest/driver-api/iio/buffers.html#c.iio_device_attach_buffer > > > > > > Yes, we've thought about this way before. But I think it would be better to give the circular buffer pointer to the application via the read function? > > I generally think that makes sense I guess the question is if we make the buffer dynamic or not. I am inclined to allow the application to resize the buffer if the ref count on it is 0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
