xiaoxiang781216 commented on a change in pull request #2036:
URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508328623
##########
File path: drivers/serial/serial.c
##########
@@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected)
void uart_reset_sem(FAR uart_dev_t *dev)
{
nxsem_reset(&dev->xmitsem, 0);
- nxsem_reset(&dev->recvsem, 0);
+ nxsem_reset(&dev->recvsem, 1);
Review comment:
The strange is that we always initialize dev->recvsem with 0, but reset
it to 1.
What do you think this?
nxsem_reset(&dev->recvsem, dev->recvwaiting);
which reset dev->recvsem to 0 in most case just like init but to 1 in the
abnormal condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
