davids5 commented on a change in pull request #2036:
URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508536838



##########
File path: drivers/serial/serial.c
##########
@@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected)
 void uart_reset_sem(FAR uart_dev_t *dev)
 {
   nxsem_reset(&dev->xmitsem,  0);
-  nxsem_reset(&dev->recvsem,  1);
+
+  /* Wake up reading function if it is blocked */
+
+  if (dev->recvwaiting)

Review comment:
       Can you just use `uart_datareceived()` to release  the waiters and the 
rx thread and manage the `recvwaiting` state?
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to