acassis commented on a change in pull request #2049:
URL: https://github.com/apache/incubator-nuttx/pull/2049#discussion_r508880434



##########
File path: arch/arm/src/stm32l4/stm32l4_adc.c
##########
@@ -1291,10 +1331,11 @@ static int adc_setup(FAR struct adc_dev_s *dev)
   adc_putreg(priv, STM32L4_ADC_SMPR1_OFFSET, ADC_SMPR1_DEFAULT);
   adc_putreg(priv, STM32L4_ADC_SMPR2_OFFSET, ADC_SMPR2_DEFAULT);
 
+  #ifdef HAVE_ADC_RESOLUTION

Review comment:
       Hi @daniel-p-carvalho, I think @ghn-certi is talking about the "#ifdef" 
line, normally all #ifdef lines starts totally at left size even for indented 
code. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to