masayuki2009 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510671335



##########
File path: arch/arm/src/c5471/c5471_vectors.S
##########
@@ -162,7 +162,8 @@ arm_vectorirq:
 
 #if CONFIG_ARCH_INTERRUPTSTACK > 3
        ldr     sp, .Lirqstackbase      /* SP = interrupt stack base */
-       str     r1, [sp]                /* Save the user stack pointer */
+       sub sp, #4              /* Adjust SP (minus 4-byte offset) */
+       str     r1, [sp]                        /* Save the xcp address */

Review comment:
       Done
   

##########
File path: arch/arm/src/armv7-r/arm_vectors.S
##########
@@ -179,9 +179,10 @@ arm_vectorirq:
        mov             fp, #0                                  /* Init frame 
pointer */
        mov             r0, sp                                  /* Get r0=xcp */
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 3
+#if CONFIG_ARCH_INTERRUPTSTACK > 7
        ldr             sp, .Lirqstackbase              /* SP = interrupt stack 
base */
-       str             r0, [sp]                                /* Save the 
user stack pointer */
+       sub             sp, #8                                  /* Adjust SP 
(minus 8-byte offset) */
+       str             r0, [sp]                                /* Save the xcp 
address */

Review comment:
       Done
   

##########
File path: arch/arm/src/armv7-r/arm_vectors.S
##########
@@ -890,9 +891,10 @@ arm_vectorfiq:
        mov             fp, #0                                  /* Init frame 
pointer */
        mov             r0, sp                                  /* Get r0=xcp */
 
-#if CONFIG_ARCH_INTERRUPTSTACK > 3
+#if CONFIG_ARCH_INTERRUPTSTACK > 7
        ldr             sp, .Lfiqstackbase              /* SP = interrupt stack 
base */
-       str             r0, [sp]                                /* Save the 
user stack pointer */
+       sub             sp, #8                                  /* Adjust SP 
(minus 8-byte offset) */
+       str             r0, [sp]                                /* Save the xcp 
address */

Review comment:
       Done
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to