xiaoxiang781216 commented on a change in pull request #2116:
URL: https://github.com/apache/incubator-nuttx/pull/2116#discussion_r511971833
##########
File path: arch/sim/Kconfig
##########
@@ -134,10 +134,7 @@ endif
config SIM_NETDEV
bool "Simulated Network Device"
default y
- depends on NET_ETHERNET
- select ARCH_HAVE_NETDEV_STATISTICS
- select SCHED_LPWORK
- select SIM_WALLTIME
+ depends on (NET_ETHERNET && SIM_WALLTIME && ARCH_HAVE_NETDEV_STATISTICS
&& SCHED_LPWORK)
Review comment:
ARCH_HAVE_NETDEV_STATISTICS is designed to be selected, and the most
place select SCHED_LPWORK, not depend on SCHED_LPWORK. so it's better to change:
depends on NET_ETHERNET && SIM_WALLTIME
select ARCH_HAVE_NETDEV_STATISTICS
select SCHED_LPWORK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
