v01d commented on a change in pull request #2131:
URL: https://github.com/apache/incubator-nuttx/pull/2131#discussion_r512758107



##########
File path: libs/libxx/Kconfig
##########
@@ -22,6 +22,34 @@ config HAVE_CXX
 
 if HAVE_CXX
 
+choice
+       prompt "C++ Library"
+       default NUTTXCXX
+
+config NUTTXCXX
+       bool "NuttX C++ library"

Review comment:
       Please just be consistent. Otherwise when looking at the macro name you 
will not know what it refers to. A rename should involve renaming many other 
things.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to