xiaoxiang781216 commented on a change in pull request #2064: URL: https://github.com/apache/incubator-nuttx/pull/2064#discussion_r517847619
########## File path: boards/sim/sim/sim/scripts/Make.defs ########## @@ -72,11 +72,16 @@ NM = $(CROSSDEV)nm OBJCOPY = $(CROSSDEV)objcopy OBJDUMP = $(CROSSDEV)objdump +# Note: -fshort-wchar for the case where NuttX and the host OS have +# differnt wchar_t. On Nuttx, it's uint16_t. On macOS, it's 32-bit. CFLAGS := $(ARCHWARNINGS) $(ARCHOPTIMIZATION) \ - $(ARCHCPUFLAGS) $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS) -pipe + $(ARCHCPUFLAGS) $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS) -pipe \ + -fshort-wchar Review comment: PREPROCESS is most used to process nx template file to generate c source files, so template files aren't C files, but the generated files are. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org