xiaoxiang781216 commented on pull request #2222: URL: https://github.com/apache/incubator-nuttx/pull/2222#issuecomment-729392591
> > Yes, it is used, but all configs can build fine by removing compiler_stdint.h. So I think it is redundant and should be removed. > > * the majority of configs relies on it providing _uintmax_t and _intmax_t. If we make uint64_t/int64_t same as compiler want, can typedef uintmax_t/intmax_t to uint64_t/int64_t match compiler expectation? If the answer is false, I still prefer to typedef _uintmax_t and _intmax_t in arch's inttype.h like other type, because the consistence is also important: ``` No Short Cuts Reducing effort at the expense of Quality, Portability, or Consistency. ``` > * it serves as an assertion to ensure the compiler types matches arch types.h. > The printf annotation can do the same thing, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
