v01d commented on a change in pull request #2335:
URL: https://github.com/apache/incubator-nuttx/pull/2335#discussion_r526320269
##########
File path: boards/Makefile
##########
@@ -98,13 +98,28 @@ $(CXXOBJS): %$(OBJEXT): %.cxx
$(BIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
+
+%.dd: %.c
+ $(Q) $(MKDEP) $(DEPPATH) "$(CC)" -- $(CFLAGS) -- $< > $@
+
+%.ddxx: %.cxx
+ $(Q) $(MKDEP) $(DEPPATH) "$(CC)" -- $(CXXFLAGS) -- $< > $@
+
+makedepfile: $(patsubst %.c,%.dd,$(SRCS))
+ @for f in $^; do cat $$f; done >> Make.dep
+ $(call DELFILE, $^)
+
+makedepxxfile: $(patsubst %.cxx,%.ddxx,$(CXXSRCS))
+ @for f in $^; do cat $$f; done >> Make.dep
+ $(call DELFILE, $^)
.depend: Makefile $(SRCS) $(TOPDIR)$(DELIM).config
+ $(call DELFILE, Make.dep)
Review comment:
I considered that initially, but in that case we're getting into OS
dependant handling of parallelization. Make already handles how to run the jobs
in parallel and also deals with the -j flag (also via MAKEFLAGS). We would be
redoing a lot of that.
I prefer to do a Make based solution.
Maybe I can define per-file .dd targets, which would not require one pattern
per case (something in the lines of how targets are defined for applications).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
