btashton commented on a change in pull request #2464: URL: https://github.com/apache/incubator-nuttx/pull/2464#discussion_r534744734
########## File path: boards/arm/sam34/sam4s-xplained-pro/configs/nsh/defconfig ########## @@ -56,7 +55,6 @@ CONFIG_NSH_STRERROR=y CONFIG_PIPES=y CONFIG_PREALLOC_MQ_MSGS=8 CONFIG_PREALLOC_TIMERS=4 -CONFIG_PTHREAD_STACK_DEFAULT=4096 Review comment: Yeah I would prefer to take the defaults as you did, I just would want to make sure the enabled features still work. If you can verify that I am happy to take this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org