fjpanag commented on pull request #2477:
URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-739921688


   > What are the style issues?
   
   Sorry, I was not careful enough. Fixed, pushing in a moment.
   
   > What about using mV 3300 instead of the the Float value?
   
   I think it is much more clear to use the proper unit of measure, instead of 
an arbitrary multiple.  
   Everyone is always referring to a board voltage in V, not mV.  
   Also, it does not seem to have any serious impact, or be dangerous in any 
way...
   
   If you insist, I can change this now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to