xiaoxiang781216 commented on a change in pull request #2572:
URL: https://github.com/apache/incubator-nuttx/pull/2572#discussion_r546530139
##########
File path: fs/spiffs/src/spiffs_vfs.c
##########
@@ -408,7 +416,8 @@ static int spiffs_open(FAR struct file *filep, FAR const
char *relpath,
/* Check of the file object already exists */
- ret = spiffs_find_objhdr_pgndx(fs, (FAR const uint8_t *)relpath, &pgndx);
+ ret = spiffs_find_objhdr_pgndx(fs, (FAR const uint8_t *)spiffs_relpath,
Review comment:
> one place? you mean three?
>
we need change at least spiffs_open, spiffs_unlink, spiffs_rename and
spiffs_stat with the current patch. On the other hand, if we enhance
spiffs_find_objhdr_pgndx to support the name without leading '\', all
spiffs_xxx don't need change.
And these patches also don't need anymore:
fs/spiffs/Kconfig: Update the description of SPIFFS_NAME_MAX
spiffs: Fix statfs f_namelen
> i can change it if you feel strongly.
> but i guess it isn't the biggest issue for this PR.
> the incompatibility with older nuttx is.
Yes, the padding added inside spiffs_pgobj_ndxheader_s is more critical than
others. We need reference the offical spiffs to see how they define this
structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
