MTres19 opened a new pull request #2641:
URL: https://github.com/apache/incubator-nuttx/pull/2641


   ## Summary
   
   I got caught by the fact that CAN messages [are 
packed](https://nuttx.apache.org/docs/latest/components/drivers/character/can.html?highlight=usage%20note)
 into the buffer passed to read() and thought there was a problem in 
can_poll(), so I started browsing through the code. Functionally there's 
nothing _wrong_ with the current code, but I thought it was strange that the 
poll setup could in theory block on the RX fifo semaphore rather than the 
designated poll semaphore. This would only happen if there was a read() call 
blocked in another thread, which I admit is an unusual use-case.
   
   If this looks acceptable I can try to clean up the TX code as well.
   
   ## Impact
   No impact expected.
   
   ## Testing
   Tested with a TM4C123GXL Launchpad using my [WIP 
driver](https://github.com/MTres19/incubator-nuttx/tree/MTres19/tiva-can). 
[Test 
application](https://github.com/MTres19/ETCetera-tools/blob/main/cantest_main.c#L352).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to