btashton commented on a change in pull request #2654:
URL: https://github.com/apache/incubator-nuttx/pull/2654#discussion_r551760293
##########
File path: tools/configure.sh
##########
@@ -296,7 +296,7 @@ done
if [ "X${defappdir}" = "Xy" ]; then
# In-place edit can mess up permissions on Windows
- # sed -i -e "/^CONFIG_APPS_DIR/d" "${dest_config}"
Review comment:
> maybe this instance can be replaced with kconfig-tweak too
Looks like the commented section can be removed and the next line updated.
It was coping to a temporary file editing via sed and moving back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
