Ouss4 commented on a change in pull request #555: URL: https://github.com/apache/incubator-nuttx-apps/pull/555#discussion_r552509026
########## File path: netutils/argtable3/Make.defs ########## @@ -0,0 +1,23 @@ +############################################################################ +# Copyright 2020 Espressif Systems (Shanghai) PTE LTD +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +############################################################################ + +ifneq ($(CONFIG_ESPAPPS_ARGTABLE3),) +CONFIGURED_APPS += $(APPDIR)/external/argtable3 + +CFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)" "$(APPDIR)/external/argtable3/argtable3/"} +CXXFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)" "$(APPDIR)/external/argtable3/argtable3/"} Review comment: The paths need to be adapted now that this is in netutils. ########## File path: netutils/iperf/Make.defs ########## @@ -0,0 +1,20 @@ +############################################################################ +# Copyright 2020 Espressif Systems (Shanghai) PTE LTD +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +############################################################################ + +ifneq ($(CONFIG_EXAMPLES_IPERF),) +CONFIGURED_APPS += $(APPDIR)/external/iperf Review comment: Similar as above, paths need to be adapted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
