Ouss4 commented on pull request #2674: URL: https://github.com/apache/incubator-nuttx/pull/2674#issuecomment-759628332
> That driver looks a little suspect to me usually you so not want a STOP in the register read. That's not a STOP, that's a repeated start. The chain is: start - write (set reg to read from) in this case - repeated start - read - stop. > NOSTOP is implied in the first message if the NOSTART flag is set on the second one. Drivers are inconsistent about it they set that flag on the first message or leave it 0 but this is what our interface contract says. If by NOSTOP you mean repeated start then no, NOSTART just means that the following message(s) are a continuation. There is no need to reconfigure and no need to send a repeated start. It's just a bunch of bytes read or written one after the other. (getting a bit out of topic for this PR, sorry!) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
