davids5 commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557547287
########## File path: canutils/slcan/slcan.c ########## @@ -0,0 +1,504 @@ +/**************************************************************************** + * apps/canutils/slcan/slcan.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <stdio.h> +#include <unistd.h> +#include <nuttx/clock.h> +#include <sched.h> +#include <fcntl.h> +#include <errno.h> +#include <stdlib.h> +#include <nuttx/fs/fs.h> +#include <nuttx/arch.h> +#include <string.h> +#include <time.h> +#include <ctype.h> +#include <net/if.h> +#include <sys/time.h> +#include <sys/types.h> +#include <sys/ioctl.h> +#include <sys/socket.h> +#include <sys/uio.h> +#include <net/if.h> +#include <termios.h> +#include <nuttx/can.h> +#include <netpacket/can.h> + +#include "slcan.h" + +/**************************************************************************** + * Defines + ****************************************************************************/ + +#define DEFAULT_PRIORITY 100 +#define DEFAULT_STACK_SIZE 2048 + +#ifdef CONFIG_SLCAN_TRACE +# define DEBUG 1 +#else +# define DEBUG 0 +#endif + +#define debug_print(fmt, ...) \ Review comment: Can we use syslog here? ########## File path: canutils/slcan/slcan.h ########## @@ -0,0 +1,47 @@ +/**************************************************************************** + * apps/canutils/slcan/slcan.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef SLCAN_H +#define SLCAN_H + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* S6 - CAN speed 500 kBit/s + * S8 - CAN speed 1 Mbit/s + * O - open channel + * C - close channel + * C + * S8 + * O + * F -> return status flags + */ +#define SLCAN_REC_FIFO_FULL (1 << 0) +#define SLCAN_SND_FIFO_FULL (1 << 1) +#define SLCAN_ERROR_WARN (1 << 2) +#define SLCAN_DATA_OVERRUN (1 << 3) +#define SLCAN_ERROR_PASSIVE (1 << 5) +#define SLCAN_ARBITRATION_LOST (1 << 6) +#define SLCAN_BUS_ERROR (1 << 7) + +/* T1401557F8f601000000▒0 */ Review comment: Is this a test command? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
