juniskane commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r560853705
##########
File path: crypto/mbedtls/Kconfig
##########
@@ -0,0 +1,18 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig CRYPTO_MBEDTLS
+ bool "Mbed TLS Cryptography Library"
+ default n
Review comment:
Consider adding:
`depends on DEV_URANDOM_RANDOM_POOL || DEV_URANDOM_ARCH`
to safe-guard against naive user building this with unsuitable options (e.g.
`DEV_URANDOM_CONGRUENTIAL` or `DEV_URANDOM_XORSHIFT128`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
