btashton commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r563533366
##########
File path: crypto/mbedtls/Kconfig
##########
@@ -0,0 +1,25 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+menuconfig CRYPTO_MBEDTLS
+ bool "Mbed TLS Cryptography Library"
+ default n
+ ---help---
+ Enable support for Mbed TLS.
+
+if CRYPTO_MBEDTLS
+
+config MBEDTLS_VERSION
+ string "MBEDTLS Version"
+ default "2.25.0"
+
+config MBEDTLS_DEFAULT_TASK_STACKSIZE
+ int "Mbed TLS app default stack size"
+ default 8192
Review comment:
So what are you thinking is the right thing for some of these apps?
DEFAULT_TASK_STACKSIZE wont work for most of them. The an especially bad
offender is the app for testing parsing CRL it allocates a 100KB buffer on the
stack right away (I don't know why they don't use the heap for this...)
https://github.com/ARMmbed/mbedtls/blob/6fbff5b557efe661cc019ef59f42c835524e9bf2/programs/x509/crl_app.c#L75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
