acassis commented on a change in pull request #2832:
URL: https://github.com/apache/incubator-nuttx/pull/2832#discussion_r572948095
##########
File path: arch/xtensa/src/esp32/esp32_allocateheap.c
##########
@@ -130,6 +132,10 @@
void up_allocate_heap(FAR void **heap_start, size_t *heap_size)
{
board_autoled_on(LED_HEAPALLOCATE);
+#ifdef CONFIG_XTENSA_IMEM_REGION_SIZE_MAX
+ *heap_size = 0x2000;
Review comment:
hi @cwespressif please avoid using this hard-coded value (0x2000).
Please create a macro symbol to represent this value. This value is used in
more than one place, then defining it will simplify case someone want to modify
it. Other (better) option is adding it as an option config and setup the
minimum and maximum range the user can choose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
