hotislandn commented on a change in pull request #2865:
URL: https://github.com/apache/incubator-nuttx/pull/2865#discussion_r579030655



##########
File path: libs/libc/machine/risc-v/common/arch_elf.c
##########
@@ -42,6 +42,26 @@
 
 #define RVI_OPCODE_MASK 0x7F
 
+/* ELF32 and ELF64 definitions */
+
+#ifdef CONFIG_LIBC_ARCH_ELF_64BIT
+#  define ARCH_ELF_TYP_STR    "64"
+#  define ARCH_ELF_CLASS      ELFCLASS64
+#  define ARCH_ELF_RELTYPE    ELF64_R_TYPE
+#  define ARCH_ELF_HDR_STR    Elf64_Ehdr
+#  define ARCH_ELF_REL_STR    Elf64_Rel
+#  define ARCH_ELF_SYM_STR    Elf64_Sym

Review comment:
       This can be removed, check the last part of file 
:https://github.com/apache/incubator-nuttx/blob/master/include/elf64.h.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to