Ouss4 commented on a change in pull request #2888:
URL: https://github.com/apache/incubator-nuttx/pull/2888#discussion_r580265500
##########
File path: boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
##########
@@ -259,6 +264,24 @@ int esp32_bringup(void)
}
#endif
+#ifdef CONFIG_SENSORS_BMP180
+ ret = board_bmp180_initialize(0, 0);
+
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize BMP180
+ Driver for I2C0: %d\n", ret);
+ ret2 = board_bmp180_initialize(0, 1);
Review comment:
> there isn't a way to know in which I2C is the BMP180 wired in
In boards we should know to what I2C bus a device is connected. In some
it's soldered. Here, it's just the fact that you are using an external device
that makes it possible to have it in two different buses.
What we do with external devices is to have instructions in the board's
README.txt to explain how the connections were made and where the code expects
the external device to be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
