[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #2899: Unify socket into file system to avoid the code duplication

[GitBox]

gustavonihei commented on a change in pull request #2899:
URL: https://github.com/apache/incubator-nuttx/pull/2899#discussion_r581103147



##########
File path: net/socket/accept.c
##########
@@ -284,7 +278,7 @@ int accept(int sockfd, FAR struct sockaddr *addr, FAR 
socklen_t *addrlen)
   return newfd;
 
 errout_with_socket:
-  sockfd_release(newfd);
+  close(newfd);

Review comment:
       We should not call the close(), since it sets a cancellation point.
   ```suggestion
     nx_close(newfd);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org