xiaoxiang781216 commented on pull request #2906: URL: https://github.com/apache/incubator-nuttx/pull/2906#issuecomment-784974674
> Sure you can argue "shoot em all " and let the linker sort it out. :) > > I would do it so that the intent of the of why it was added is documented is it not enough with the comment before valloc? And it isn't good to mention LTP in a general function. > and left off and turned on for the project that wants to use it. NuttX already contains so many Kconfig, and it's already impossible to test all combination now. If the tool can do the selection automatically, it's wrong to add Kconfig in this case, because: 1. It make harder to test all option combination 2. Beginner also hard to do the right configuration > If not it may end up C&P at litter that is not garbage collected. Since valloc contained in a standalone file, even the oldest linker can remove the unused object files without problem. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
