[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #2908: signal: set SIGRTMIN to SIGUSR1 because signo 0 don't catch.

Wed, 24 Feb 2021 05:49:16 -0800 


Donny9 commented on a change in pull request #2908:
URL: https://github.com/apache/incubator-nuttx/pull/2908#discussion_r581972780



##########
File path: include/signal.h
##########
@@ -43,7 +43,7 @@
 
 #define NULL_SIGNAL_SET ((sigset_t)0x00000000)
 #define ALL_SIGNAL_SET  ((sigset_t)0xffffffff)
-#define MIN_SIGNO       0
+#define MIN_SIGNO       1
 #define MAX_SIGNO       31

Review comment:
       > 
   > 
   > The title says SIGRTMIN to SIGUSR1
   > 
   > But isn't this the bit position? Not the mapping?
   
   I misdescribed it, i will modify this title. sorry~




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to