yamt commented on pull request #2983: URL: https://github.com/apache/incubator-nuttx/pull/2983#issuecomment-791273648
> @yamt could you please squash the two commits? I think since it's a new file with no code leveraged, it does matter where the license came from. i don't think it's appropriate to squash them. it isn't "a new file with no code leveraged". it's a code extracted from the existing file. so it should inherit the original copyright notice. the license change is a logically independent change. it's in the same PR just because we have a policy to avoid adding a file with non apache license. > > BTW, I've got a few changes for this layout that I'm about to push. It changes a bit the layout and introduces a couple of regions (mostly in SMP). ok. do you want to make your change in before this one? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
