microhobby commented on a change in pull request #3082:
URL: https://github.com/apache/incubator-nuttx/pull/3082#discussion_r596201016



##########
File path: tools/version.sh
##########
@@ -81,6 +82,14 @@ if [ -z ${VERSION} ] ; then
 
 fi
 
+if [ -z ${EXTRA} ] ; then
+  EXTRA=`git -C ${WD} tag --sort=v:refname | grep -E 
"nuttx-[0-9]+\.[0-9]+\.[0-9]+" | tail -1 | cut -d'-' -f3`

Review comment:
       @xiaoxiang781216 @Ouss4 thanks for the review.
   Yeah I agree, and use the remaining of the cut directly in VERSION looks 
good to me.
   I updated the commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to