gustavonihei commented on a change in pull request #3102: URL: https://github.com/apache/incubator-nuttx/pull/3102#discussion_r597630740
########## File path: mm/iob/iob_destroy_queue.c ########## @@ -0,0 +1,92 @@ +/**************************************************************************** + * mm/iob/iob_destroy_queue.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <assert.h> + +#include <nuttx/mm/iob.h> + +#include "iob.h" + +#if CONFIG_IOB_NCHAINS > 0 + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifndef NULL +# define NULL ((FAR void *)0) +#endif + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: iob_destroy_queue + * + * Description: + * Destroy all I/O buffer chains from the iob queue. + * + ****************************************************************************/ + +void iob_destroy_queue(FAR struct iob_queue_s *qhead, + enum iob_user_e producerid) +{ + FAR struct iob_qentry_s *iobq; + FAR struct iob_qentry_s *nextq; + FAR struct iob_s *iob; + + /* Detach the list from the queue head so first for safety (should be safe + * anyway). + */ + + iobq = qhead->qh_head; + qhead->qh_head = NULL; + + /* Remove each I/O buffer chain from the queue */ + + while (iobq) Review comment: ```suggestion while (iobq != NULL) ``` For pointer validation, being more verbose improves readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
