fjpanag commented on a change in pull request #3050:
URL: https://github.com/apache/incubator-nuttx/pull/3050#discussion_r599630746
##########
File path: drivers/syslog/syslog_channel.c
##########
@@ -135,14 +139,82 @@ static int syslog_default_putc(int ch)
int syslog_channel(FAR const struct syslog_channel_s *channel)
{
+#if (CONFIG_SYSLOG_MAX_CHANNELS != 1)
+ int i;
+#endif
+
DEBUGASSERT(channel != NULL);
if (channel != NULL)
{
DEBUGASSERT(channel->sc_putc != NULL && channel->sc_force != NULL);
- g_syslog_channel = channel;
+#if (CONFIG_SYSLOG_MAX_CHANNELS == 1)
+ g_syslog_channel[0] = channel;
return OK;
+#else
+ for (i = 0; i < CONFIG_SYSLOG_MAX_CHANNELS; i++)
+ {
+ if (g_syslog_channel[i] == NULL)
+ {
+ g_syslog_channel[i] = channel;
+ return OK;
+ }
+ else if (g_syslog_channel[i] == channel)
+ {
+ return OK;
+ }
+ }
+#endif
+ }
+
+ return -EINVAL;
+}
+
+/****************************************************************************
+ * Name: syslog_channel_remove
+ *
+ * Description:
+ * Removes an already configured SYSLOG channel from the list of used
+ * channels.
+ *
+ * Input Parameters:
+ * channel - Provides the interface to the channel to be removed.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success. A negated errno value is returned
+ * on any failure.
+ *
+ ****************************************************************************/
+
+int syslog_channel_remove(FAR const struct syslog_channel_s *channel)
Review comment:
No this is not real output.
But still I cannot understand this.
`lib_sprintf()` is finally calling the `putc(c,stream)` macro, which may end
up to a plain call to `syslog_putc()`.
I don't see any buffering take place, that will concatenate all
`lib_sprintf()` calls to a single string to be outputed atomically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
