acassis commented on a change in pull request #3163:
URL: https://github.com/apache/incubator-nuttx/pull/3163#discussion_r600718552



##########
File path: drivers/usbdev/rndis.c
##########
@@ -2474,20 +2498,19 @@ static int usbclass_setup(FAR struct 
usbdevclass_driver_s *driver,
               }
             else if (ctrl->req == RNDIS_GET_ENCAPSULATED_RESPONSE)
               {
-                if (!priv->ctrlreq_has_encap_response)
+                if (priv->response_queue_bytes == 0)
                   {
+                    /* No reply available is indicated with a single 0x00 
byte. */
                     ret = 1;
                     ctrlreq->buf[0] = 0;
                   }
                 else
                   {
-                    /* There is data prepared in the ctrlreq buffer.
-                     * Just assign the length.
-                     */
-
+                    /* Retrieve a single reply from the response queue to 
control request buffer. */

Review comment:
       Yes, you are right! I was looking the first two commits only




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to