v01d commented on a change in pull request #3170: URL: https://github.com/apache/incubator-nuttx/pull/3170#discussion_r600812470
########## File path: libs/libc/unistd/lib_getoptvars.c ########## @@ -0,0 +1,153 @@ +/**************************************************************************** + * libs/libc/unistd/lib_getoptvars.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <unistd.h> +#include <pthread.h> + +#include "unistd.h" +#include "libc.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define INVALID_KEY CONFIG_TLS_NELEM +#define VALID_KEY(key) ((key) >= 0 && key < CONFIG_TLS_NELEM) + +/* Configuration. Currently no thread-specific data destructors. */ + +#undef HAVE_DESTRUCTOR +#define HAVE_CLEANUP 1 +#define HAVE_TLSVARS 1 + +/* Check if we have some way to avoid a memory leak */ + +#if defined(CONFIG_DISABLE_PTHREAD) || !defined(CONFIG_PTHREAD_CLEANUP) +# undef HAVE_CLEANUP +#endif + +/* Don't use TLS if we cannot avoid the memory leak or if TLS is disabled */ + +#if (!defined(HAVE_DESTRUCTOR) && !defined(HAVE_CLEANUP)) || \ + CONFIG_TLS_NELEM == 0 +# undef HAVE_TLSVARS +#endif + Review comment: Is disabling pthread common? I would have assumed that it is kind of required for some parts of the OS. Would the extra space be in FLASH mostly? If so, I think the linker usually throws away unused functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
