xiaoxiang781216 commented on a change in pull request #3160: URL: https://github.com/apache/incubator-nuttx/pull/3160#discussion_r601005758
########## File path: arch/risc-v/src/esp32c3/esp32c3_std_atomic.c ########## @@ -0,0 +1,284 @@ +/**************************************************************************** + * arch/risc-v/src/esp32c3/esp32c3_std_atomic.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdbool.h> +#include <stdint.h> +#include <nuttx/arch.h> +#include <nuttx/irq.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define CMP_EXCHANGE(n, type) \ + \ + bool __atomic_compare_exchange_ ## n (type *mem, \ + type *expect, \ + type desired, \ + int success, \ + int failure) \ + { \ + bool ret = false; \ + irqstate_t irqstate = enter_critical_section(); \ Review comment: spinlock is different from the critical section even in no SMP case: 1. Can't wait inside the spinlock 2. Can wait inside the critical section To support the wait, the critical section has much more complex logic than spinlock. All code which don't require sleep should switch to spinlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
