v01d commented on a change in pull request #3170: URL: https://github.com/apache/incubator-nuttx/pull/3170#discussion_r604132622
########## File path: libs/libc/unistd/lib_getoptvars.c ########## @@ -0,0 +1,83 @@ +/**************************************************************************** + * libs/libc/unistd/lib_getoptvars.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <unistd.h> +#include <assert.h> + +#include <nuttx/tls.h> +#include <nuttx/lib/libvars.h> + +#include <arch/tls.h> + +#include "unistd.h" +#include "libc.h" + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +#ifdef CONFIG_BUILD_KERNEL +/* Data is naturally process-specific in the KERNEL build so no special + * access to process-specific global data is needed. + */ + +FAR struct getopt_s g_getopt_vars = +{ + NULL, + 0, + 1, + '?', + NULL, + false +}; +#endif + Review comment: Maybe add the field names in this initializer, so it is clearer and also safer if more elements are ever added to the struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
