patacongo commented on pull request #3259: URL: https://github.com/apache/incubator-nuttx/pull/3259#issuecomment-811073434
First of all, I think we need to determine if this is a case if the inappropriate inclusion of 3rd part code without proper attribution. My understanding is that the copyright does not cover re-use of the algorithm, only the code. Seeing local variables with the same name is a clue that the code was re-used. Courtesy and good engineering etiquette would, I think, demand that we acknowledge the author/inventor in some way and reflect this in the licensing. I think that to incorporate 3rd part party code we need to: - Get some approval/concurrence from the author, - Retain the author's license header as required by the terms of the license for code reuse - Add the reference to the 3rd party code to the LICENSE file. Is that right? We can include 3rd party code, we just need to do it correctly and ethically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
