xiaoxiang781216 commented on a change in pull request #3319:
URL: https://github.com/apache/incubator-nuttx/pull/3319#discussion_r607039222
##########
File path: net/tcp/tcp_netpoll.c
##########
@@ -97,7 +97,18 @@ static uint16_t tcp_poll_eventhandler(FAR struct
net_driver_s *dev,
/* A poll is a sign that we are free to send data. */
- else if (psock_tcp_cansend(info->psock) >= 0)
+ /* Wake up poll() speculatively on TCP_ACKDATA.
+ * Note: our event handler is usually executed before
+ * psock_send_eventhandler, which might free IOBs/WRBs on TCP_ACKDATA.
+ * Revisit: consider some kind of priority for devif callback to allow
Review comment:
Yes, maybe we can order the flag value by priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
