davids5 commented on pull request #3471: URL: https://github.com/apache/incubator-nuttx/pull/3471#issuecomment-815979356
@xiaoxiang781216 I am trying to review it..... if this `(sp < istackbase && sp >= istackbase - istacksize)` is `(sp < istackTOP && sp >= istackTOP - istacksize)` Then I think the change is wrong. based on >Given FD-DB-IA - A test for a valid Stack would be clear: > >'sp > lowerbound && sp <= upperbound` > >'lowerbound == sp - is invalid as a push (DB) at this point would be out of bounds. It is valid if in the context of a handler that can NOT call deeper but will ONLY return pop (IA) >upperbound` == sp - is valid if the stake is unused, as push is DB. It is invalid the context of a handler that will ONLY return pop (IA) The correct test is: (sp <= istackTOP && sp > istackTOP - istacksize) I am missing something or do you agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
