xiaoxiang781216 commented on a change in pull request #3508: URL: https://github.com/apache/incubator-nuttx/pull/3508#discussion_r611091177
########## File path: boards/arm/stm32/nucleo-f103rb/src/stm32_appinit.c ########## @@ -24,27 +24,16 @@ #include <nuttx/config.h> -#include <sys/types.h> -#include <syslog.h> - #include <nuttx/board.h> -#include <nuttx/leds/userled.h> #include "nucleo-f103rb.h" /**************************************************************************** * Pre-processor Definitions ****************************************************************************/ -#undef HAVE_LEDS -#undef HAVE_DAC - -#if !defined(CONFIG_ARCH_LEDS) && defined(CONFIG_USERLED_LOWER) -# define HAVE_LEDS 1 -#endif - -#if defined(CONFIG_DAC) -# define HAVE_DAC 1 +#ifndef OK Review comment: why need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org