jlaitine commented on a change in pull request #3523:
URL: https://github.com/apache/incubator-nuttx/pull/3523#discussion_r611382313
##########
File path: tools/mksyscall.c
##########
@@ -497,14 +515,16 @@ static void generate_stub(int nfixed, int nparms)
* value, just return zero (OK).
*/
- if (strcmp(g_parm[RETTYPE_INDEX], "void") == 0)
+ fprintf(stream, ");\n");
+ if (strcmp(g_parm[RETTYPE_INDEX], "noreturn") == 0)
{
- fprintf(stream, ");\n return 0;\n}\n");
+ fprintf(stream, " PANIC();\n");
Review comment:
True! It is enough not to generate the "return 0" there. I will fix this
asap...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
