xiaoxiang781216 commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-817828085
> There is really too many unrelated changes in this PR to review properly. It should be separated into several PRs that can be properly reviewed. The rename change is already separated to a new patch, you can review it here: https://github.com/apache/incubator-nuttx/pull/3517/commits/401d8cce169340e50fe74487bb8a3ed9144c086a The rest change relate to each other: 1. Allocate the space from the lowest stack(up_stack_frame) 2. The stack dump/check need adjust because adj_stack_ptr point to the low end of stack 3. TLS data need to explicitly be allocated by up_stack_frame to ensure it's address always equals stack_alloc_ptr 4. vfork also need adjust since the implementation of vfork couple with how the stack memory allocate You can review this patch here: https://github.com/apache/incubator-nuttx/pull/3517/commits/07f0019fe0ecb53f3870069408dabfc57949307a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
